Hi,
I'm attaching an additional (incremental) patch that fixes additional
use of the filename. It is only initialized there as a string without
being used as such. Therefore, this should be removed to not confuse the
other use of it (as a code reference).
Looks like this part of the code has never been tested before. ;)
(A colleague of mine discovered this, feel free to ask me if the issue
(and resolution) is still unclear.)
bye,
Roland
--- libhttp-proxy-perl-0.20/lib/HTTP/Proxy/BodyFilter/save.pm.orig
2007-07-23 11:29:16.000000000 +0200
+++ libhttp-proxy-perl-0.20/lib/HTTP/Proxy/BodyFilter/save.pm 2007-07-23
11:31:48.000000000 +0200
@@ -92,7 +92,6 @@
$file = File::Spec->rel2abs( $file );
# internal data initialisation
- $self->{_hpbf_save_filename} = "";
$self->{_hpbf_save_fh} = undef;
# create the directory
@@ -132,7 +131,6 @@
}
# we have an open filehandle
- $self->{_hpbf_save_filename} = $file.$ext;
binmode( $self->{_hpbf_save_fh} ); # for Win32 and friends
$self->proxy->log( HTTP::Proxy::FILTERS, "HPBF::save",
"Saving $uri to $file$ext" );
