Package: filerunner
Version: 2.5.1-12
Severity: dangerous
hi,
I've lost data using fr to move files from a local dir to a remote
smb-mounted volume, on which the selected dest dir wasn't present.
The situation was as follows:
local fs:
/mnt/smb/path/to/my_stuff/dir
remote smb fs:
/path/to/my_stuff
mount remote on /mnt/smb:
/mnt/smb[/path/to/my_stuff]
fr was open on /mnt/smb/path/to/my_stuff/dir before mounting the smb volume,
hence it did still see /dir when 'moving' - ie I managed to click on 'move'
before refresh took place.
I think fr should 1st copy then delete on success, like other utils do.
A (not totally failsafe) patch could be as follow:
#----------------------------------------
--- /usr/lib/filerunner/cmd.tcl.orig 2007-07-26 11:42:47.000000000 +0200
+++ /usr/lib/filerunner/cmd.tcl 2007-07-26 11:41:29.000000000 +0200
@@ -371,6 +371,12 @@
global config glob
upvar $filelist_var filelist
+ set r [catch {file mkdir $topwd}]
+ if {$r} {
+ tk_dialog .apop "Hey Dimwit!" \
+ "Destination $topwd is not a dir (anymore)?!?" "" 0 "OK"
+ return {}
+ }
foreach sel [$listb_name curselection] {
if {[CheckAbort "Move"]} return
set elem [lindex $filelist $sel]
#----------------------------------------
thanks
--
paolo
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
