On Sat, Jul 28, 2007 at 12:15:30PM +0200, Ola Lundqvist wrote:
> > +           if command -v mail >/dev/null; then
> 
> Why do you use "command" instead of just checking with -x?
> Like
> 
> if [ -x "$(which fmail)" ] ; then

Habit out of maintainer scripts that does not need any special shell
features. It is common practice in maintainer scripts. In the package
itself, I do not care too much, and -x which is as good as the command
constructs, I guess.

> > -   mail -s "$SUBJECT" "$MAILTO" < "$MAIL"
> > -   rm -f "$MAIL"
> >      fi
> 
> Shouldn't this $MAIL file be removed even if the mail command can
> not be found?

Yes, it should.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 3221 2323190


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to