Package: procmail
Version: 3.22-16
Severity: minor

The lockfile(1) manpage lists the following example:

      ...
      lockfile important.lock
      ...
      access_"important"_to_your_hearts_content
      ...
      rm -f important.lock
      ...

In the context of a shell script. By default (that is, without set -e),
this is in adequate.

To emphasis the requirement to check the exit code, I suggest replacing

"""
  lockfile important.lock
"""

by

"""
  # Make sure to abort if the lockfile could not be created!
  lockfile important.lock || exit 1
"""

--Jeroen

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages procmail depends on:
ii  libc6                       2.3.6.ds1-13 GNU C Library: Shared libraries

Versions of packages procmail recommends:
ii  exim4                         4.63-17    metapackage to ease exim MTA (v4) 
ii  exim4-daemon-light [mail-tran 4.63-17    lightweight exim MTA (v4) daemon

-- no debconf information

-- 
Jeroen van Wolffelaar
[EMAIL PROTECTED] (also for Jabber & MSN; ICQ: 33944357)
http://Jeroen.A-Eskwadraat.nl


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to