clone 435807 -1 reassign -1 slim # breaks many many many shell scripts severity -1 grave retitle -1 slim does not cleanse environment thanks
On Fri, Aug 03, 2007 at 05:04:43PM +0200, Pierre Habouzit wrote:
> Ookay, for some reason, I have resume set to /dev/sda5 ... and well,
> git-am uses resume. I *HATE* sh for that. If you have _any_ idea of what
> could clutter my env, you'd be welcomed.
I've tracked that down, not really a git problem... but the login
manager I tried recently is completely dumb and does not cleanse the
environment before launching X, and I have a lot of env preset,
including resume set to /dev/sda5, init to /sbin/init, and many many
other lowercased environment variables that are bound to disturb some
shell scripts.
This is a very grave problem, that could affects many many packages.
OTOH git should _not_ be affected by such issues, and should unset
every local variable it uses at the begin of every git shell script. In
fact I'd argue that git should filter the env of any lowercased
variable, something like:
tounset=`env|cut -f1 -d=|grep -v '[A-Z]'`
unset $tounset tounset
should vaguely do it.
Cheers,
--
·O· Pierre Habouzit
··O [EMAIL PROTECTED]
OOO http://www.madism.org
pgpghhzTLxXVR.pgp
Description: PGP signature
