Hi again On 8/6/07, Loïc Minier <[EMAIL PROTECTED]> wrote: > > Sure; will you import it in collab-maint?
done. svn+ssh://[EMAIL PROTECTED]/svn/collab-maint/ext-maint/moap/trunk/debian To the review: > 1) I recommend you wrap your build-deps; this makes it easier to read > SVN diffs or diffs between two versions of the package for review or > when merging from another distro (think Ubuntu or other derivatives) understand. !2) Please add a XV-Python-Version XB, yes, it was here, and for some stupid reasons I removed it. Now it's back. 3) Please set XS-Python-Version to >= 2.3 instead of all; this includes > more precise information and will give you the same result here, but > without any doubt if one tries to backport moap for example. Sounds good! !4) The full license grant is required; it's the text you can find in > upstream source files which states "I'm giving you permission to use > these sources under the GPL, you should have received etc." Ok. I think I will have to fix this again in vala :( - this was not clear for me. !5) Please drop the useless debian/dirs Yeah. !6) Either use DEB_PYTHON_SYSTEM / CDBS support in rules or call > dh_pysupport manually, but not both. Ok. I have to call it manually, since moap is using autotools (right?) !7) Please drop the debian/source.lintian-overrides file; it hides a > real error. Oups! I really thought it was included in the dist (I checked, but anyway, my bad) Debian generate it.. does that means that I have to patch make distclean? 8) You might want to add a watch file. Yeah! let's try to do that. ok done. (the motu have done a nice page) !9) Since you're not using a patch series, please name your patch > starting with an index so that you can later on insert patches before > or after this patch; for example name it > debian/patches/60_remove-doc-from-distclean.patch. Did you send it > upstream? It would be cool to use/understant quilt. It seems to be popular nowadays. Any pointer? Renamed. I fixed this bug with Thomas during GUADEC. So yes ;) 10) You might want to run the testsuite on build. Unfortunately, it does not pass without bleeding edge. I know Thomas has been working on improving this situation. 11) You might want to patch Ubuntu specific strings to add a Debian > flavor. Which one? !12) You miss dependencies on python-librdf, python-cheetah, > python-genshi, exuberant-ctags etc. Please don't list all of these as > Depends but use Depends/Recommends/Suggests as best fits. Hmm.. Based on my own feeling ;) Otherwise, looked good; I didn't check dependencies yet. > Pbuilder etch looks happy. Salut :) -- Marc-André Lureau, GSmartMix
