tag 436325 -patch +confirmed thanks [adding tcltk maintainers to cc list]
Hi Cyril! Sorry, I think your "patch" tag is a bit to fast; at least I'm not yet sure if it's ppracers fault, nor if what's the proper way to fix it. * Cyril Brulebois <[EMAIL PROTECTED]> [070807 03:23]: > this is due to the empty -I flag. It looks like it comes from the > following configure.in snippet: (else case). > | if test "x$with_tcl_inc" != "x"; then > | TCL_CFLAGS="-I$with_tcl_inc" > | AC_MSG_NOTICE(["Using custom TCL headers directory: $with_tcl_inc"]) > | else > | TCL_CFLAGS="-I$TCL_INC_DIR $TCL_INCLUDE_SPEC" > | fi > > Indeed, TCL_INCLUDE_SPEC contains the appropriate path, whereas > TCL_INC_DIR is empty. I guess it is sufficient to conditionally add > ``-I$TCL_INC_DIR'' only if TCL_INC_DIR isn't empty. > > After editing src/Makefile manually: > -CXXFLAGS = -g -O2 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I > -I/usr/include/tcl8.4 -I/usr/include/freetype2 > +CXXFLAGS = -g -O2 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT > -I/usr/include/tcl8.4 -I/usr/include/freetype2 > > I've been able to build successfully the .deb's, so I guess you can > focus on fixing configure.in's code. I'm not yet sure if it's ppracer configure beeing wrong. It's sourcing /usr/lib/tcl8.4/tclConfig.sh to get those variables, and the script shipped with tcl8.4-dev_8.4.12-1.1 did contain TCL_INC_DIR. The one shipped with tcl8.4-dev_8.4.15-1 does not. So I'm wondering, why Tcls behaviour changed? Lucas, have there been other Tcl related FTBFS? BTW: We don't need to patch configure, Makefiles or configure.in; calling configure with "--with-tcl-inc=/usr/include/tcl8.4/tcl-private/generic" works, too. But before uploading with that change, I would really like to hear input from tcl maintainers. Yours sincerely, Alexander
signature.asc
Description: Digital signature
