On Thursday 09 August 2007, you wrote: > Applied for the next upload. Thx Lamont.
> Should it do something similar when reading the clock, do you think?
Not needed because of chrony as that is started way later, but in general it
does seem like a good idea. In that case however I would suggest to print an
error in case of a failure as it is likely to be a lot more problematic if
the system clock cannot be _set_. I would expect hwclock to be disabled
completely for systems that really do not support it.
Maybe:
# Set and announce the local time.
if /sbin/hwclock --hctosys $GMT $HWCLOCKPARS $BADYEAR; then
verbose_log_action_msg "System Clock set. Local time: `date $UTC`"
else
log_failure_msg "Unable to set System Clock. Local time: `date $UTC`"
fi
Or maybe use log_warning_msg instead.
BTW, please drop the trailing period in the following statements as
log_action_msg already adds one by default, so you currently print two:
log_action_msg "Setting the system clock."
log_action_msg "Saving the system clock."
Cheers,
FJP
signature.asc
Description: This is a digitally signed message part.
