tags 437508 + patch
thanks

Hi Geoff

On Mon, Aug 13, 2007 at 10:03:16AM +1000, Geoff Crompton wrote:
> Package: debarchiver
> Version: 0.7.3
> Severity: normal
> 
> Hi, it seems if someone writes a syntax error in /etc/debarchiver.conf, the
> script silently ignores that problem.
> 
> I had a look at the code, I think the problem may be in opalmod, line 152 of 
> OpaL::action says:
>     150 sub pdebug ($$;&) {
>     151     my ($lvl,$message,$ref) = @_;
>     152     if ($debuglvl >= $lvl) {
>     153         if ($message !~ /\n$/) {
>     154             $message = $message . "\n";
>     155         }
>     156         print ("$ERRLVL{$lvl}: $message");
>     157     }
>     158     exitlvl($lvl,$ref);
>     159     return;
>     160 }
> 
> when I was using the perl debugger, instead of line 152 causing the error to 
> be printed it skipped down to line 158 and called exitlvl().
> 
> Similarly at line 173 where it decides in exitlvl() not to exit the program.

No the problem is not in OpaL::action. Instead it is the severity level of the
problem that is wrong. It is set to 4 which means informational message. The
informational messages are not printed by default.

A fix will be to change the level to 3 which means warning.

If you change line the lines that contain "Loading config file" in the 
debarchiver
command from:

 pdebug(4, "Loading config file...

to

 pdebug(3, "Loading config file...

it will solve this problem.

If you could verify this soltion, it would be good. If it works for you, I'll
upload a new version with that fix.

Best regards,

// Ola

> -- System Ieformation:
> Debian Release: 4.0
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: i386 (i686)
> Shell:  /bin/sh linked to /bin/bash
> Kernel: Linux 2.6.18-4-xen-686
> Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
> 
> Versions of packages debarchiver depends on:
> ii  adduser                     3.102        Add and remove users and groups
> ii  apt-utils                   0.6.46.4-0.1 APT utility programs
> ii  dpkg-dev                    1.13.25      package building tools for Debian
> ii  opalmod                     0.1.14       A set of Perl modules for 
> various 
> 
> debarchiver recommends no packages.
> 
> -- no debconf information
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  [EMAIL PROTECTED]                     Annebergsslingan 37      \
|  [EMAIL PROTECTED]                     654 65 KARLSTAD          |
|  http://opalsys.net/                 +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to