Hi Apparently I've been a little quick on my analysis of the problem. The platform field is not a replacement, more to the point not all machines provide a "machine" field.
The platform field will always be there, the machine field may not. The machine field provides more precise informations than the platform one. Examples: on a pmac G5: platform : PowerMac machine : PowerMac11,2 on a Pegasos II CHRP machine: platform : CHRP machine : CHRP Pegasos2 but on PS3: platform : PS3 (no "machine" field). The problem is the machine field always appear /after/ the platform one. So we have two options: 1/ only use the platform field (easy solution, one liner patch) 2/ be smarter and use platform if we don't have a machine field, but this involves more code (temporary storage of the platform value until we can assert whether or not we have a machine field), which might be a little overkill. Alternatively we could probably add the content of the machine field into the "features" section of the info collected by the client (apparently that's what the OSX client does) The patch I sent isn't really wrong in any case, it will just always pick the platform field since it comes first, but it could be made simpler if we settle on option 1... HTH -- Thibaut VARENE http://www.parisc-linux.org/~varenet/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
