Package: debhelper
Version: 5.0.53
Severity: wishlist

--- Please enter the report below this line. ---
Hi,

I used dh-make to generate (among others) a debian/rules file for a package. 
In that file, the 'clean:' rule mentions "-$(MAKE) clean".
The leading slash of that command causes lintian to complain about 
possible "make clean" errors being ignored during the package build. 
(debian-rules-ignores-make-clean-error)

I'm reporting this as "wishlist", since debian/rules is supposed to be edited 
by hand anyway, so IMHO the presence of the leading dash is more a "lack of 
confort" than a bug.

The problem is present in the single binary, multiple binary, library, and 
kernel module dh-make templates ; attached is a patch that corrects it.

Best regards.
-- 
David

--- System information. ---
Architecture: i386
Kernel:       Linux 2.6.22-1-686

Debian Release: lenny/sid
  500 unstable        www.debian-multimedia.org 
  500 unstable        havtknut.tihlde.org 
  500 unstable        ftp.gajim.org 
  500 unstable        ftp.fr.debian.org 
  500 unstable        download.tuxfamily.org 
  500 testing         security.debian.org 

--- Package information. ---
Depends            (Version) | Installed
============================-+-==============
perl           (>= 5.6.0-16) | 5.8.8-7
coreutils                    | 5.97-5.4
file             (>= 3.23-1) | 4.21-3
dpkg-dev        (>= 1.13.13) | 1.14.5
html2text                    | 1.3.2a-3
binutils                     | 2.18~cvs20070812-1
po-debconf                   | 1.0.9
--- /usr/share/debhelper/dh_make/debiank/rules	2007-01-07 23:27:42.000000000 +0100
+++ dh_make/debiank/rules	2007-08-28 21:48:56.000000000 +0200
@@ -125,7 +125,7 @@
 	rm -f build-arch-stamp build-indep-stamp #CONFIGURE_STAMP#
 
 	# Add here commands to clean up after the build process.
-	-#CLEAN#
+	#CLEAN#
 
 	dh_clean
 
--- /usr/share/debhelper/dh_make/debianl/rules	2006-06-02 13:03:28.000000000 +0200
+++ dh_make/debianl/rules	2007-08-28 21:49:01.000000000 +0200
@@ -46,7 +46,7 @@
 	rm -f build-stamp #CONFIGURE_STAMP#
 
 	# Add here commands to clean up after the build process.
-	-#CLEAN#
+	#CLEAN#
 
 	dh_clean#PRESERVE#
 
--- /usr/share/debhelper/dh_make/debianm/rules	2006-06-02 13:03:27.000000000 +0200
+++ dh_make/debianm/rules	2007-08-28 21:49:13.000000000 +0200
@@ -51,7 +51,7 @@
 	rm -f build-arch-stamp build-indep-stamp #CONFIGURE-STAMP#
 
 	# Add here commands to clean up after the build process.
-	-#CLEAN#
+	#CLEAN#
 
 	dh_clean#PRESERVE#
 
--- /usr/share/debhelper/dh_make/debians/rules	2006-06-02 13:03:28.000000000 +0200
+++ dh_make/debians/rules	2007-08-28 21:48:21.000000000 +0200
@@ -39,7 +39,7 @@
 	rm -f build-stamp #CONFIGURE_STAMP#
 
 	# Add here commands to clean up after the build process.
-	-#CLEAN#
+	#CLEAN#
 
 	dh_clean#PRESERVE#
 

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to