Package: gtkpod
Followup-For: Bug #441308

Since lsof showed lots [> 500] opened mp3 files I decided to see if I
could spot [the absense of] a missing fclose() call in the gtkpod
source code.  I did.  Adding the fclose() call fixes the problem.
I've attached the patch.

Note: I am not a gtkpod developer.  I do know C, so I think my patch
doesn't screw anything up; however, as I've only looked for a missing
fclose() call and not familiarised myself with the code, I could have
overlooked something.


- Felix

-- 
Felix C. Stegerman <[EMAIL PROTECTED]>                  http://obfusk.net
~ "Any sufficiently advanced bug is indistinguishable from a feature."
~   -- R. Kulawiec
~ vim: set ft=mail tw=70 sw=2 sts=2 et:
diff -Naur -p gtkpod-0.99.10-old/src/mp3file.c gtkpod-0.99.10/src/mp3file.c
--- gtkpod-0.99.10-old/src/mp3file.c	2007-06-27 21:29:33.000000000 +0200
+++ gtkpod-0.99.10/src/mp3file.c	2007-09-08 17:03:17.000000000 +0200
@@ -2354,6 +2354,7 @@ gboolean mp3_get_track_lame_gapless (gch
     /* total samples minus pre/postgap */
     gd->samplecount = totalframes * mysamplesperframe - gd->pregap - gd->postgap;
 
+    fclose(file);
     return TRUE;
 
 

Attachment: signature.asc
Description: Digital signature

Reply via email to