* Andrei Popescu <[EMAIL PROTECTED]> [2007-09-08 21:30]:
> If I comment out 'query_on_start' it works.
Yes, that makes sense. I'm not sure whether FreeDB tagging can be
supported properly when you specify both query_on_start and
cont_failed_query. The problem is that jack thinks the query failed and
doesn't really know that you entered something manually. There's an
--edit-freedb option which you could also specify.
My proposed solution for this problem is this: if both query_on_start
and cont_failed_query are set and theer's no FreeDB entry, ask the user
whether they want to edit the FreeDB data. If they do, the file will be
properly tagged.
Would that solution be okay for you?
You'd see something like this:
3281:[EMAIL PROTECTED]: ~/tmp/jack] jack -Q --cont-failed-query -t 1
This is jack 3.1.1 (C)2004 Arne Zellentin <[EMAIL PROTECTED]>
*info* querying...
*warning* 202 No match for disc ID 7f0e030a. How about trying another
--server?
freedb search failed, continue? (y/N) y
Do you want to edit the freedb data? (y/N)
Patch:
--- jack_prepare.py~ 2007-09-09 10:41:05.000000000 +0200
+++ jack_prepare.py 2007-09-09 11:00:57.000000000 +0200
@@ -506,8 +506,13 @@
x = raw_input("\nfreedb search failed, continue? (y/N) ") + "x"
if not x or x[0].upper() != "Y":
sys.exit(0)
- cf['_query_on_start'] = 0
- cf['_set_id3tag'] = 0
+ if not cf['_edit_freedb']:
+ x = raw_input("\nDo you want to edit the freedb data? (y/N) ")
+ "x"
+ if x and x[0].upper() == "Y":
+ cf['_edit_freedb'] = 1
+ else:
+ cf['_query_on_start'] = 0
+ cf['_set_id3tag'] = 0
else:
jack_display.exit()
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
