Package: qiv
Version: 2.1~pre12-2+b1
Severity: normal
Tags: patch

I tried making a qiv-command to rename files, and imagine my surprise
when all the names were truncated.  I tracked the problem to utils.c,
which allows much shorter commands than can be accumulated in event.c.
To guarantee consistency, this size really ought to go in a .h file,
but here is a quick patch that solves the problem.

Norman

--- utils.c.orig        2007-04-25 02:50:56.000000000 +0100
+++ utils.c     2007-09-09 12:33:39.000000000 +0100
@@ -239,7 +239,7 @@
 /* run a command ... */
 void run_command(qiv_image *q, char *n, char *filename, int *numlines, const 
char ***output)
 {
-  static char nr[10];
+  static char nr[100];  /* matches command buffer in event.c */
   static char *buffer = 0;
   static const char *lines[MAXLINES + 1];
   int pipe_stdout[2];

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (50, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-1-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages qiv depends on:
ii  gdk-imlib11                  1.9.15-3    imaging library for use with gtk
ii  libc6                        2.6.1-1+b1  GNU C Library: Shared libraries
ii  libglib1.2ldbl               1.2.10-19   The GLib library of C routines
ii  libgtk1.2                    1.2.10-18.1 The GIMP Toolkit set of widgets fo
ii  libx11-6                     2:1.0.3-7   X11 client-side library
ii  libxext6                     1:1.0.3-2   X11 miscellaneous extension librar
ii  libxi6                       2:1.1.2-1   X11 Input extension library
ii  libxinerama1                 1:1.0.2-1   X11 Xinerama extension library

qiv recommends no packages.

-- no debconf information
--- utils.c.orig        2007-04-25 02:50:56.000000000 +0100
+++ utils.c     2007-09-09 12:33:39.000000000 +0100
@@ -239,7 +239,7 @@
 /* run a command ... */
 void run_command(qiv_image *q, char *n, char *filename, int *numlines, const char ***output)
 {
-  static char nr[10];
+  static char nr[100];  /* matches command buffer in event.c */
   static char *buffer = 0;
   static const char *lines[MAXLINES + 1];
   int pipe_stdout[2];

Reply via email to