Package: tkcvs
Version: 8.0.4-1
Severity: normal

Every time ~/.tkcvs is saved (i.e. wken tkcvs exits), the value of
cvscfg(editorargs) is appended to cvscfg(editor).

Reading through the code, it appears that cvscfg(editorargs) is being
deprecated - thus it adds the contents to cvscfg(editor). 

Unfortunately, it it doesn't clear (only removes) cvscfg(editorargs), so
every time tkcvs exits, cvscfg(editor) is appended to. Until it
eventually fails. 

The attached patch appears to fix that.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.21-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_GB.ISO-8859-15, LC_CTYPE=en_GB.ISO-8859-15 (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages tkcvs depends on:
ii  cvs                         1:1.12.13-8  Concurrent Versions System
ii  subversion                  1.4.4dfsg1-1 Advanced version control system
ii  tcl8.4                      8.4.15-1     Tcl (the Tool Command Language) v8
ii  tk8.4                       8.4.15-1     Tk toolkit for Tcl and X11, v8.4 -
ii  tkdiff                      1:4.1.3-1    graphical side by side "diff" util

Versions of packages tkcvs recommends:
pn  dirdiff                       <none>     (no description available)
ii  gnome-terminal [x-terminal-em 2.18.1-1   The GNOME 2 terminal emulator appl
ii  konsole [x-terminal-emulator] 4:3.5.7-3  X terminal emulator for KDE
ii  xterm [x-terminal-emulator]   229-1      X terminal emulator

-- no debconf information
Only in tkcvs-8.0.4.kj: build-stamp
diff -r -u tkcvs-8.0.4.kj/debian/changelog tkcvs-8.0.4/debian/changelog
--- tkcvs-8.0.4.kj/debian/changelog     2007-09-13 09:30:03.000000000 +0100
+++ tkcvs-8.0.4/debian/changelog        2007-09-13 09:33:12.000000000 +0100
@@ -1,10 +1,3 @@
-tkcvs (8.0.4-1.1) unstable; urgency=low
-
-  * cvscfg(editorargs) is now cleared. This prevents cvscfg(editorargs) from
-    being appended to cvscfg(editor) every time ~/.tkcvs is rewritten.
-
- -- Karl E. Jorgensen <[EMAIL PROTECTED]>  Thu, 13 Sep 2007 09:29:15 +0100
-
 tkcvs (8.0.4-1) unstable; urgency=low
 
   * New upstream version (Closes: #375686, #399391)
Only in tkcvs-8.0.4.kj/debian: files
Only in tkcvs-8.0.4.kj/debian: tkcvs
Only in tkcvs-8.0.4.kj/debian: tkcvs.postinst.debhelper
Only in tkcvs-8.0.4.kj/debian: tkcvs.postrm.debhelper
diff -r -u tkcvs-8.0.4.kj/tkcvs/workdir.tcl tkcvs-8.0.4/tkcvs/workdir.tcl
--- tkcvs-8.0.4.kj/tkcvs/workdir.tcl    2007-09-13 09:28:40.000000000 +0100
+++ tkcvs-8.0.4/tkcvs/workdir.tcl       2007-05-10 03:28:57.000000000 +0100
@@ -1575,7 +1575,7 @@
     if {$cvscfg(editorargs) != ""} {
       set cvscfg(editor) [concat $cvscfg(editor) $cvscfg(editorargs)]
     }
-    set cvscfg(editorargs) ""
+    unset cvscfg(editorargs)
   }
 
   # Save the list so we can keep track of what we've done

Reply via email to