On 15/09/2007, Andrew Schulman <[EMAIL PROTECTED]> wrote:
>
> Amos, thanks for submitting the patch.  On line 23 you have:
>
> +    my @files = ref $file ? @$file : [ $file ];
>
> Are you sure this is right?  It looks wrong to me.  I think it should be
>
> +    my @files = ref $file ? @$file : ( $file );


Yes it looks like you are right.


> Also, although the patch is 170 lines, it seems that only about a dozen or
> so are substantive; the rest are just changes in whitespace.  It might be
> better to resubmit the patch with whitespace ignored, to make the
> substantive changes clearer.


OK, will try to get to it.

Andrew.


Thanks for the feedback.

--Amos

Reply via email to