On Fri, 2007-09-21 at 10:25 +0100, martin f krafft wrote: > also sprach Hanspeter Kunz <[EMAIL PROTECTED]> [2007.09.21.1017 +0100]: > > I didn't mean that the submission rules are unspecific. What > > I meant is, that the logcheck rules I submitted are unspecific, > > because it is their purpose to match a lot of different lines > > (with the same straing pattern though) in syslog. > > Yes, I know. But the submission rules say that your rules are not > acceptable and that you should put .+$ after them, because "those > are the rules, but I did not make them".
Ok, if there is no technical reason, why every rule should end with $ I would suggest to change the rules then. To have .*$ at the end of a rule really makes no sense to me. > > And the fact that you do not worry about performance does not mean > > that I shouldn't, does it? :-) > > If you do, please concentrate your energy on other parts of logcheck > which are much greater performance hogs than regexps processed by > egrep. :) fair enough. But having more efficient rules is already a start :) > > So, in short: I am convinced that the (logcheck) rules I submitted > > are best kept as they are (not using an $ at the end), because it > > is their intention to be unspecific. > > > > If you agree, I can also submit them as a patch. > > I am fine with your rules. You don't need to make a patch, but if > you want, please go ahead. git is fun to play with. Ok. I had enough fun today already ;-) I will play with git next time. cheers, Hp. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]