On Sun, Sep 16, 2007 at 10:35:39PM +0200, Giacomo Catenazzi wrote: > Steve Langasek wrote: > > On Sun, Sep 16, 2007 at 04:57:21PM +0200, Giacomo A. Catenazzi wrote: > >> Package: libfreetype6-dev > >> Version: 2.3.5-1+b1 > >> Severity: normal
> >> In /usr/include/ft2build.h there is a line: > >> #include <freetype/config/ftheader.h> > >> but this file file is not in the usual C include path, > >> so change it to: > >> #include <freetype2/freetype/config/ftheader.h> > > No, packages that build with libfreetype6-dev are expected to use the > > include path settings provided by pkg-config --cflags freetype2. > No ;-) > It is supposed that including a #include <header.h> will > not break C code. You suppose wrong. There are lots of ways that this can break, including setting an incorrect -I option that results in pulling a header from a subdir under the wrong name. > If the "pkg-config --cflags freetype2" is required, you should > move the ft2build.h from /usr/include/ to /usr/include/freetype2/ > so that the file will be found only if the right pkg-config is found. Well, I don't see any reason that ft2build.h needs to be in /usr/include directly, but I also don't find any reason that it needs to be moved into the subdirectory. So I'm not going to make any particular effort to move this header, unless you see that the placement is somehow a Debian-specific bug that I can fix by /removing/ code. Otherwise, please discuss the placement of this header with upstream if you think it needs to change. BTW, the header states at the top: /* This is a Unix-specific version of <ft2build.h> that should be used */ /* exclusively *after* installation of the library. */ /* */ /* It assumes that `/usr/local/include/freetype2' (or whatever is */ /* returned by the `freetype-config --cflags' or `pkg-config --cflags' */ /* command) is in your compilation include path. */ So at least the current placement doesn't appear to be accidental. > BTW, personally I find "pkg-config" only "hacks" for local installations, > but a distribution IMHO should already install and put together things > in a better way, but maybe this will be a future step. No, it won't be. There are many libraries where pkg-config is the standard upstream convention used to specify include/library paths, and applications which want to use these libraries portably will always need to use pkg-config. And pkg-config is far better than all preceding solutions anyway. Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
