Package: galeon
Version: 2.0.2-4
Severity: serious
Tags: patch

--- Please enter the report below this line. ---
Trying to open the print dialog (e.g. ctrl-P) crashes galeon (this
happened after I did some system updates; I _think_ the version of
galeon didn't change but some libs, and I hope its reproducible with a
pure debian-unstable installation).

Somehow deleting the dummy-entry of the printer combo-box of the
print dialog window now sets the active index to -1, and the already
installed callback function gets called and crashes. The patch is a
workaround, I'm not sure what really changed.

The third change in the patch stops the crashes, the first 2 changes in
the patch save the value of priv->selected_printer which gets changed by
a callback function when the dummy entry in name_combo is deleted.

--- print-dialog.c      Wed Sep 26 19:57:29 2007
+++ galeon-2.0.2/embed/print-dialog.c   Mon Jan  2 13:32:50 2006
@@ -363,7 +363,7 @@
        {
                GList *i;
                GtkWidget *name_combo, *paper_combo;
-               int selected_printer = priv->selected_printer;
+
                name_combo = galeon_dialog_get_control(dialog, NAME_PROP);
                paper_combo = galeon_dialog_get_control(dialog, PAPER_PROP);
 
@@ -376,8 +376,8 @@
                                                  ((EmbedPrintInfo 
*)i->data)->name);
                }
                gtk_combo_box_set_active(GTK_COMBO_BOX(name_combo),
-                                        selected_printer);
-               priv->selected_printer =selected_printer;
+                                        priv->selected_printer);
+
                gul_pu_set_combobox_from_config(paper_combo, CONF_PRINT_PAPER);
        }
 
@@ -671,10 +671,9 @@
 
        priv->selected_printer =
                        gtk_combo_box_get_active(GTK_COMBO_BOX(name_combo));
+
        info = (EmbedPrintInfo *)g_list_nth_data(priv->printers,
                                                 priv->selected_printer);
-        if (!info)
-            return;
 
        gtk_widget_set_sensitive(command_entry, info->can_change_command);
 

 --- System information. ---
Architecture: i386
Kernel:       Linux 2.6.21-2-686

Debian Release: lenny/sid
  500 unstable        ftp.de.debian.org 
  500 testing         security.debian.org 
  500 testing         ftp.de.debian.org 
  500 stable          security.debian.org 
  500 stable          ftp.de.debian.org 
  500 proposed-updates ftp.de.debian.org 

--- Package information. ---
Depends                           (Version) | Installed
===========================================-+-===============
libart-2.0-2                    (>= 2.3.18) | 2.3.19-3
libatk1.0-0                     (>= 1.20.0) | 1.20.0-1
libbonobo2-0                    (>= 2.15.0) | 2.20.0-1
libbonoboui2-0                  (>= 2.15.1) | 2.20.0-1
libc6                          (>= 2.6.1-1) | 2.6.1-5
libcairo2                        (>= 1.4.0) | 1.4.10-1
libfontconfig1                   (>= 2.4.0) | 2.4.2-1.2
libgcc1                        (>= 1:4.2.1) | 1:4.2.1-5
libgconf2-4                     (>= 2.13.5) | 2.20.0-1
libglade2-0                    (>= 1:2.6.1) | 1:2.6.2-1
libglib2.0-0                    (>= 2.14.0) | 2.14.1-3
libgnome-desktop-2              (>= 2.11.1) | 2.20.0-2
libgnome2-0                     (>= 2.17.3) | 2.20.0-1
libgnomecanvas2-0               (>= 2.11.1) | 2.20.0-1
libgnomeui-0                    (>= 2.17.1) | 2.20.0-1
libgnomevfs2-0               (>= 1:2.17.90) | 1:2.20.0-1
libgtk2.0-0                     (>= 2.12.0) | 2.12.0-2
libice6                        (>= 1:1.0.0) | 2:1.0.4-1
libmozjs0d                     (>= 1.8.1.5) | 1.8.1.6-1
libnspr4-0d                   (>= 1.8.0.10) | 4.6.7-1
liborbit2                     (>= 1:2.14.1) | 1:2.14.7-0.1
libpango1.0-0                   (>= 1.18.2) | 1.18.2-1
libpopt0                          (>= 1.10) | 1.10-3
libsm6                                      | 2:1.0.3-1+b1
libstartup-notification0         (>= 0.8-1) | 0.9-1
libstdc++6                       (>= 4.2.1) | 4.2.1-5
libx11-6                                    | 2:1.0.3-7
libxcomposite1                 (>= 1:0.3-1) | 1:0.3.2-1+b1
libxcursor1                      (>> 1.1.2) | 1:1.1.9-1
libxdamage1                      (>= 1:1.1) | 1:1.1.1-3
libxext6                                    | 1:1.0.3-2
libxfixes3                     (>= 1:4.0.1) | 1:4.0.3-2
libxi6                                      | 2:1.1.3-1
libxinerama1                                | 1:1.0.2-1
libxml2                         (>= 2.6.29) | 2.6.30.dfsg-2
libxrandr2                     (>= 2:1.2.0) | 2:1.2.2-1
libxrender1                                 | 1:0.9.4-1
libxul0d                       (>= 1.8.1.4) | 1.8.1.6-1
procps                                      | 1:3.2.7-3
galeon-common                               | 2.0.2-4





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to