On Mon, Oct 01, 2007 at 01:46:23PM +0200, Luca Capello wrote: > Cc:ing upstream author, since this bug is clearly upstream and I'd > like his opinion about my patch.
Thanks. In the future, please attach the patches uncompressed and inline. It makes me able to comment on them inside the mail. I know darcs is nice, but their patch format sucks for human reading, so using diff -u format would be highly appreciated too, at least for discussion. For (much) more information on this, I recommend you to read http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;hb=HEAD, specially point 7. > On Tue, 21 Nov 2006 20:25:59 +0100, Philipp Kern wrote: > > darcsweb appends `/etc/darcsweb' to sys.path in line 29. This fails if > > another `config.py' is in the path before the one specifying darcs's > > configuration. In my case this was presumably > > `var/lib/python-support/python2.4/config.py'. It makes sense. > > Instead it should prepend the path to the variable. > > Or, better, use a less generic name. That would have been nice, but sadly it breaks backwards compatibility and I don't think it's worth it. > And while we're at here, I'd suggest to move the configuration to > /etc/darcswebconf.py (even if the best would be /etc/darcsweb.conf), > since AFAIK /etc/darcsweb/ contains config.py only. Upstream patch > attached. Maybe a better solution that doesn't breaks backward compatibility is to add /etc/darcsweb at the second place in sys.path. I don't want to put it in front because it would prevent you from having a /etc/darcsweb/config.py and then another darcsweb install with a local configuration. Any thoughts on that fix? Thanks a lot, Alberto -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
