Package: rkhunter
Version: 1.3.0-1
Severity: normal

Hi,

I suggest the following improments of the cron scripts:

· In the daily script, you check for “! $NICE”, but you source the
  defaults config after this. I think better is something like this:
  . /etc/default/rkhunter

  if [ -z "$NICE" ]; then
      NICE=0
  fi

  or to check for numbers:
  case "$NICE" in
    [0-9]|[01][0-9]) ;;
    *) NICE=0;;
  esac

  But I prefer the first one.

· What do you check with “[ $(stat -c %s $OUTFILE) -ne 0 ]”? Is this the
  same as “[ -s "$OUTFILE" ]”?

· (weekly script) Is it intended that the OUTFILE gets overwritten by the
  second call of rkhunter? Otherwise you should use this line:
  ($RKHUNTER --versioncheck; $RKHUNTER --update) 1>/dev/null 2>$OUTFILE
  or use >> in the second call.

Bye, Jörg.

-- System Information:
Debian Release: unstable/experimental
  APT prefers unstable
  APT policy: (900, 'unstable'), (700, 'experimental')
Architecture: powerpc (ppc)

Kernel: Linux 2.6.22-rc6
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages rkhunter depends on:
ii  debconf [debconf-2.0]         1.5.14     Debian configuration management sy
ii  exim4-daemon-light [mail-tran 4.67-8     lightweight Exim MTA (v4) daemon
ii  file                          4.21-3     Determines file type using "magic"
ii  net-tools                     1.60-17    The NET-3 networking toolkit
ii  perl                          5.8.8-11   Larry Wall's Practical Extraction 

Versions of packages rkhunter recommends:
ii  binutils                      2.18-1     The GNU assembler, linker and bina
ii  iproute                       20070313-1 Professional tools to control the 
pn  libmd5-perl                   <none>     (no description available)
ii  wget                          1.10.2-3   retrieves files from the web

-- debconf information excluded

Attachment: pgpnY1Qk53LUE.pgp
Description: PGP signature

Reply via email to