* Andrei Popescu <[EMAIL PROTECTED]> [2007-10-21 22:27]:
> oggi.add_tag('ALBUM', a_title.encode("utf-8"))
> AttributeError: 'NoneType' object has no attribute 'encode'
Thanks, that's all pretty embarassing. I just realized that I added
the line I asked you to remove myself. It was in response to #361290
which is exactly the bug you just saw.
...
So the line is needed, but we can move it somewhere else. This should
really fix the problem. However, it's a bit late and I might have
missed some other case.
I'll think about it some more tomorrow, but maybe you can test this
patch:
--- jack_prepare.py 2007-10-21 15:12:18.000000000 +0200
+++ jack_prepare.py 2007-10-21 22:23:14.000000000 +0200
@@ -507,7 +507,6 @@
if not x or x[0].upper() != "Y":
sys.exit(0)
cf['_query_on_start'] = 0
- cf['_set_id3tag'] = 0
else:
jack_display.exit()
@@ -546,6 +545,10 @@
error("query on start failed to give a good freedb file,
aborting.")
else:
err, jack_tag.track_names, jack_tag.locale_names, freedb_rename,
revision = jack_freedb.interpret_db_file(jack_ripstuff.all_tracks, todo,
cf['_freedb_form_file'], verb = cf['_query_on_start'], warn =
cf['_query_on_start'])
+ if cf['_cont_failed_query'] and err:
+ cf['_set_id3tag'] = 0
+ else:
+ cf['_query_on_start'] = 1
return freedb_rename
def undo_rename(status, todo):
You already removed the cf['_set_id3tag'] = 0 line, so all you have to
do is add those 4 new lines to the file.
> Sounds reasonable to me, but shouldn't these patches go upstream as
> well? (Or at least that's how I understand it works, especially for
> something that is not a distro specific fix.)
Yes, of course but unfortunately jack appears to be abandoned
upstream. I sent an email to the maintainer today asking for the
status.
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
