Package: dpatch
Version: 2.0.28
Severity: grave

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

If you think, downgrade it to important, but I think, this issue
introduces data loss.

The problem can be easily reproduced: Take a package with dpatch
support. Create a patch:

dpatch -a -0 -01_foo
(e.g. touch test, add some text to test, exit)

then talke a look at the patch and you will find the newly created file.
Now run the same command again:

dpatch -a -0 -01_foo
(e.g. touch test2, add some text to test2, exit)

and now look again into the patch. Your first change has been completely
lost. I guess, the problem is caused by the -a switch, that probably
apples the patch we want to change to the orig source too, so the
difference gets lost, because the patch has been applied to the working
and the reference tree. Maybe you just need to make sure, that only the
patches up to (and excluding) the given patch are applied to the source.

This introduces a second question: Say you have 5 patches: 01..05 and you
run

dpatch-edit-patch -a 03

Shall it apply the patch 01..02 or shall it try to put the patch 03 at
the end and apply all patches 01..02,04..05? Depending on this, I guess,
you have to solve the original problem.

Regards, Daniel


- -- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (850, 'unstable'), (700, 'testing'), (550, 'stable'), (110, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-k7 (SMP w/1 CPU core)
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

dpatch depends on no packages.

Versions of packages dpatch recommends:
ii  dpkg-dev                      1.14.11    package building tools for Debian
ii  fakeroot                      1.8.8      Gives a fake root environment
ii  patchutils                    0.2.31-4   Utilities to work with patches

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHSFq7m0bx+wiPa4wRApRCAJsFMBKZhMTkM1lMfro7MJVdV4sYAQCfVDJU
fUbuMWjZrYwNjqAWx3xhHi0=
=WIGc
-----END PGP SIGNATURE-----



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to