On 2007-12-07 Kees Cook <[EMAIL PROTECTED]> wrote:
> Package: findutils
> Version: 4.2.31-3
> Severity: normal
> Tags: patch
> User: [EMAIL PROTECTED]
> Usertags: origin-ubuntu hardy ubuntu-patch
> 
> Hello!  This patch allows the ionice values to be configured from the local
> customization file.
[...] 

> diff -u findutils-4.2.31/debian/locate-cron.daily 
> findutils-4.2.31/debian/locate-cron.daily
> --- findutils-4.2.31/debian/locate-cron.daily
> +++ findutils-4.2.31/debian/locate-cron.daily
[...]
> -if [ -x /usr/bin/ionice ]; then
> -     ionice -c3 -p$$
> -fi
> +# I/O priority
> +# 1 for real time, 2 for best-effort (3 for idle is only allowed for root!)
> +IONICE_CLASS=2
> +# 0-7 (for IONICE_CLASS 1 and 2 only), 0=highest, 7=lowest 
> +IONICE_PRIORITY=7
[...]
> +     ionice -c ${IONICE_CLASS:-2} -n ${IONICE_PRIORITY:-7} -p $$

Hello,

I had seen that patch in Ubuntu but had disregarded it. I am not
perfectly sure about ionice syntax, but I think that 
IONICE_CLASS 3 idle seems to be perfect for locate.

ionice(1) says

"-n   The scheduling class data. This defines the class data, if the
class accepts an argument. For real time and best-effort, 0-7 is valid
data."

This implies that setting -n for -c3 is a error. At the time being
ionice simply seems to ignore -n if -c3 is set, though.

Why are you defaulting to IONICE_CLASS 2 instead of 3? How is this
better? Is there some policy I am not aware of?
thanks, cu andreas
-- 
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to