Package: thunar
Version: 0.9.0-1scorpi0
Severity: normal
Tags: patch
Hi,
in the fix for http://bugzilla.xfce.org/show_bug.cgi?id=3119, Benedikt added
a function thunar_vfs_volume_is_ejectable(), so that Thunar can show an
"Eject" in the context menu of volumes that support eject. However, Thunar
only enables this if thunar_vfs_volume_is_disc() returns true, so "Eject" is
only shown for optical discs. See
http://foo-projects.org/pipermail/thunar-dev/2007-December/004291.html for
the discussion about this.
The attached patch is taken from thunar SVN and tested with 0.9.0.
Regards,
Tino
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.23.8 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages thunar depends on:
ii desktop-file-utils 0.13-2 Utilities for .desktop files
ii libatk1.0-0 1.20.0-1 The ATK accessibility toolkit
ii libc6 2.7-4 GNU C Library: Shared libraries
ii libcairo2 1.4.10-1.2 The Cairo 2D vector graphics libra
ii libdbus-1-3 1.1.2-1 simple interprocess messaging syst
ii libdbus-glib-1-2 0.74-1 simple interprocess messaging syst
ii libexo-0.3-0 0.3.4-1 Library with extensions for Xfce
ii libfreetype6 2.3.5-1+b1 FreeType 2 font engine, shared lib
ii libglib2.0-0 2.14.4-2 The GLib library of C routines
ii libgtk2.0-0 2.12.3-1 The GTK+ graphical user interface
ii libice6 2:1.0.4-1 X11 Inter-Client Exchange library
ii libpango1.0-0 1.18.3-1 Layout and rendering of internatio
ii libsm6 2:1.0.3-1+b1 X11 Session Management library
ii libthunar-vfs-1-2 0.9.0-1scorpi0 VFS abstraction used in thunar
ii libx11-6 2:1.0.3-7 X11 client-side library
ii libxfce4util4 4.4.2-1 Utility functions library for Xfce
ii shared-mime-info 0.22-2 FreeDesktop.org shared MIME databa
ii thunar-data 0.9.0-1scorpi0 Provides thunar documentation, ico
ii xfce4-panel 4.4.2-1 The Xfce4 desktop environment pane
Versions of packages thunar recommends:
ii dbus 1.1.2-1 simple interprocess messaging syst
ii gamin 0.1.9-2 File and directory monitoring syst
ii hal 0.5.10-4 Hardware Abstraction Layer
-- debconf-show failed
--- thunar-0.9.0.orig/thunar/thunar-shortcuts-view.c 2007-12-02 14:46:32.000000000 +0100
+++ thunar-0.9.0/thunar/thunar-shortcuts-view.c 2007-12-11 22:25:40.319693949 +0100
@@ -834,13 +834,12 @@
gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
gtk_widget_show (item);
- /* check if the volume is a disc */
- if (thunar_vfs_volume_is_disc (volume))
+ /* check if the volume is ejectable */
+ if (thunar_vfs_volume_is_ejectable (volume))
{
/* append the "Eject Volume" menu action */
item = gtk_image_menu_item_new_with_mnemonic (_("E_ject Volume"));
g_signal_connect_swapped (G_OBJECT (item), "activate", G_CALLBACK (thunar_shortcuts_view_eject), view);
- gtk_widget_set_sensitive (item, thunar_vfs_volume_is_ejectable (volume));
gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
gtk_widget_show (item);
}
--- thunar-0.9.0.orig/thunar/thunar-tree-view.c 2007-12-02 14:46:33.000000000 +0100
+++ thunar-0.9.0/thunar/thunar-tree-view.c 2007-12-11 22:25:40.323053852 +0100
@@ -1041,13 +1041,12 @@
gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
gtk_widget_show (item);
- /* check if the volume is a disc */
- if (thunar_vfs_volume_is_disc (volume))
+ /* check if the volume is ejectable */
+ if (thunar_vfs_volume_is_ejectable (volume))
{
/* append the "Eject Volume" menu action */
item = gtk_image_menu_item_new_with_mnemonic (_("E_ject Volume"));
g_signal_connect_swapped (G_OBJECT (item), "activate", G_CALLBACK (thunar_tree_view_action_eject), view);
- gtk_widget_set_sensitive (item, thunar_vfs_volume_is_ejectable (volume));
gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
gtk_widget_show (item);
}
