Package: inn2
Version: 2.4.3+20070806-1
Severity: minor

Hi,

Here are some suggestions regarding the package:

--- inn2-2.4.3+20070806.orig/extra/active
+++ inn2-2.4.3+20070806/extra/active
@@ -0,0 +1,8 @@
+control 0000000000 0000000000 n
+control.cancel 0000000000 0000000000 n
+control.checkgroups 0000000000 0000000000 n
+control.newgroup 0000000000 0000000000 n
+control.rmgroup 0000000000 0000000000 n
+junk 0000000000 0000000000 n
+local.general 0000000000 0000000000 y
+local.test 0000000000 0000000000 y

It should be lines like:

control 0000000000 0000000001 n

But why not use the samples/active.minimal file shipped with INN?
(Only local.* should be added to it.)



--- inn2-2.4.3+20070806.orig/extra/newsgroups
+++ inn2-2.4.3+20070806/extra/newsgroups
@@ -0,0 +1,8 @@
+control   Various control messages (no posting)
+control.cancel  Cancel messages (no posting)
+control.checkgroups Hierarchy check control messages (no posting)
+control.newgroup Newsgroup creation control messages (no posting)
+control.rmgroup  Newsgroup removal control messages (no posting)
+junk   Unfiled articles (no posting)
+local.general  Local general group
+local.test  Local test group

There should be final dots at the end of each description.
And there is also a samples/newsgroups.minimal file shipped with INN.



+++ inn2-2.4.3+20070806/debian/inn2.logcheck.violalations.ignore
                                               ^^^^

Isn't there a problem with that name?



--- inn2-2.4.3+20070806.orig/debian/inn2.links
+++ inn2-2.4.3+20070806/debian/inn2.links
@@ -0,0 +1,7 @@
+usr/share/man/man5/active.5 usr/share/man/man5/active.times.5

Why is this man page removed?
"man active.times" should not point to the active man page...



--- inn2-2.4.3+20070806.orig/debian/inn2.cron.d
+++ inn2-2.4.3+20070806/debian/inn2.cron.d
+# Enable this entry to send posted news back to your upstream provider.
+# Not if you use innfeed, of course.
+
+#*/15 * * * * news send-nntp news.myprovider.com

send-nntp is deprecated and nntpsend should be used instead, if need be.



--- inn2-2.4.3+20070806.orig/debian/changelog
+++ inn2-2.4.3+20070806/debian/changelog
@@ -0,0 +1,269 @@
+inn2 (2.4.3+20070806-1) unstable; urgency=low
+
+  * New upstream STABLE snapshot.
+  * Fixed segfaults when reloading incoming.conf (Closes:

The numbers of the bug are missing:  #361073, #429802, #430190, #430191.



--- inn2-2.4.3+20070806.orig/debian/inn2.README.Debian
+++ inn2-2.4.3+20070806/debian/inn2.README.Debian
@@ -0,0 +1,87 @@
+Please check your control.ctl file, the configuration for some popular
+hierarchies like de.*, fr.* and uk.* does not work out of the box with
+gnupg (see <[EMAIL PROTECTED]>).

Is it sure this problem still occurs with stable GnuPG?
Mine is working fine.



--- inn2-2.4.3+20070806.orig/debian/inn2.README.Debian
+++ inn2-2.4.3+20070806/debian/inn2.README.Debian
@@ -0,0 +1,87 @@
+SSL
+~~~
+To enable SSL you need to start /etc/news/bin/nnrpd-ssl with the -S
+flag from inetd or the command line.

A binary in /etc/news/bin? :)



--- inn2-2.4.3+20070806.orig/debian/inn2.init
+++ inn2-2.4.3+20070806/debian/inn2.init

I believe some stuff should be added there for SSL.
At least, in a commented form like:

start () {
   su news -c /usr/lib/news/bin/rc.news
#   su news -c '/usr/lib/news/bin/nnrpd -D -c /etc/news/readers-ssl.conf -p 563 
-S'
}

stop () {
#   su news -c 'killall nnrpd'
   su news -c '/usr/lib/news/bin/rc.news stop'
}


(Or without the specific readers-ssl.conf file if you prefer.)


I hope these remarks will help to improve the quality of the Debian package
(which is already very great by the way).

Regards,

--
Julien ÉLIE

« Bibere humanus est, ergo bibamus. »



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to