tags 425867 +patch
thanks

Hi,

The segfault problem still exists in lingot version 0.7.4-2.  The fix
also still works, and after looking at it a bit more carefully, I think
it is actually the proper thing to do.

The problem is with the red dot in the frequency viewer.  The frequency
of the peak is determined, then the height of the graph at that position
is read out of the array and that gives two coordinates (the frequency
itself and the height) for the dot.

The problem is that the peak that was found is actually outside the
array.  The height lookup then fails, because it will read invalid
memory.  The patch I provided is the hack that in this (unusual) case,
the dot will instead be on the last position in the array, so that
everything will be fine.

There is one thing wrong with the patch, though: it should say 255
instead of 256 (both times).

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply via email to