Package: wesnoth
Version: 1:1.3.13-1
Severity: minor

Hello,

The debian/rules calls configure with parameter

  CFLAGS=$(CFLAGS)

but CFLAGS is not defined anywhere, so it ends up setting CFLAGS to empty.
That means that .c files are compiled without optimization, while .cpp files
are compiled with whatever is default in configure.

As per Debian policy section 10.1, I would suggest adding CXXFLAGS=$(CFLAGS)
to also affect .cpp files and adding this before the rule:

ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
CFLAGS += -O0
else
CFLAGS += -O2
endif

It would make it easier for mere mortals to build debugging version.

Best regards,

Jan

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (100, 
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22-3-amd64 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=cs_CZ.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages wesnoth depends on:
ii  libboost-iostreams1.34. 1.34.1-4         Boost.Iostreams Library
ii  libc6                   2.7-5            GNU C Library: Shared libraries
ii  libfreetype6            2.3.5-1+b1       FreeType 2 font engine, shared lib
ii  libfribidi0             0.10.9-1         Free Implementation of the Unicode
ii  libgcc1                 1:4.3-20080104-1 GCC support library
ii  libsdl-image1.2         1.2.6-1          image loading library for Simple D
ii  libsdl-mixer1.2         1.2.8-3          mixer library for Simple DirectMed
ii  libsdl-net1.2           1.2.7-2          network library for Simple DirectM
ii  libsdl1.2debian         1.2.13-1         Simple DirectMedia Layer
ii  libstdc++6              4.3-20080104-1   The GNU Standard C++ Library v3
ii  libx11-6                2:1.0.3-7        X11 client-side library
ii  python2.4               2.4.4-7          An interactive high-level object-o
ii  wesnoth-data            1:1.3.13-1       data files for Wesnoth
ii  zlib1g                  1:1.2.3.3.dfsg-8 compression library - runtime

wesnoth recommends no packages.

-- no debconf information
-- 
                                                 Jan 'Bulb' Hudec <[EMAIL 
PROTECTED]>



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to