Package:  setserial
Version:  2.17-44
Severity: important
Tags:     patch
User:     [EMAIL PROTECTED]
Usertags: incorrect-dependency

When testing dependency based boot sequencing, I discovered a bug in
the init.d scripts for setserial.

The two init.d scripts included in the package both claim to provide
setserial, and this make update-rc.d when using dependency based boot
ordering refuse to install the scripts and the installation of the
package fail.  Because of this, I suggest to rename the provide of
etc-setserial to etc-setserial.

When checking the postinst, I discover that the scripts are only set
to start in "runlevel" S, and stop in runlevels 0 and 6, yet the
header claim they should start in runlevel 2, 3, 4 and 5, and stop in
runlevel 0, 1 and 6.  I assume the postinst script is correct, and
suggest updating the header.  Last, I discovered that the current
ordering is not properly reflected by the dependencies of the script.
etc-setserial is set to start just after checkfs, and setserial just
after all the file systems are mounted.  I updated the dependencies to
match this current ordering.

I'm setting severity to important as this issue make it impossible to
install setserial when dependency based boot sequencing is enabled.

This patch implement the change:

diff -ur setserial-2.17.orig/rc.etc-setserial setserial-2.17/rc.etc-setserial
--- setserial-2.17.orig/rc.etc-setserial        2007-02-18 18:13:12.000000000 
+0100
+++ setserial-2.17/rc.etc-setserial     2008-01-10 23:16:37.000000000 +0100
@@ -1,11 +1,11 @@
 #! /bin/sh
 #
 ### BEGIN INIT INFO
-# Provides:             setserial
-# Required-Start:       $syslog
-# Required-Stop:        $syslog
-# Default-Start:        2 3 4 5
-# Default-Stop:         0 1 6
+# Provides:             etc-setserial
+# Required-Start:       checkfs
+# Required-Stop:        $remote_fs
+# Default-Start:        S
+# Default-Stop:         0 6
 # Short-Description:    controls configuration of serial ports
 # Description:          Set and/or report the configuration information
 #                       associated with a serial port. This information
Only in setserial-2.17: rc.etc-setserial.~1~
diff -ur setserial-2.17.orig/rc.serial setserial-2.17/rc.serial
--- setserial-2.17.orig/rc.serial       2007-02-18 18:13:12.000000000 +0100
+++ setserial-2.17/rc.serial    2008-01-10 23:17:17.000000000 +0100
@@ -3,10 +3,10 @@
 #      Initializes the serial ports on your system
 ### BEGIN INIT INFO
 # Provides:            setserial
-# Required-Start:      $syslog
-# Required-Stop:       $syslog
-# Default-Start:       2 3 4 5
-# Default-Stop:                0 1 6
+# Required-Start:      $remote_fs
+# Required-Stop:       $remote_fs
+# Default-Start:       S
+# Default-Stop:                0 6
 # Short-Description:   controls configuration of serial ports
 # Description:         Set and/or report the configuration information
 #                      associated with a serial port. This information

The stop script etc-setserial do not seem to do anything.  If this is
indeed the case, I recommend removing 0 and 6 from the Default-Stop
list to save some time during shutdown.

Happy hacking,
--
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to