tag 460462 patch thanks On Sat, Jan 12, 2008 at 10:58:07PM +0100, Cyril Brulebois wrote: > Package: xfce4-fsguard-plugin > Version: 0.3.0-3 > Severity: important > > Hi,
Hi Cyril, > steps to reproduce: > - add fsguard plugin; > - configure it as you wish, e.g.: > - label = root, > - moint point = /, > - filemanager = (empty), > - alert level = 200, > - warn level = 500 > > Then one can hover the icon, get the available disk space, but when > clicking on the icon, the plugin disappears. > > ,---[ xsession errors ]--- > | ** Message: Contrôle d'espace disque: screen changed: 0 > | ** Message: No valid plug window. > | (xfce4-panel:3603): Gtk-CRITICAL **: gtk_socket_get_id: assertion > `GTK_WIDGET_ANCHORED (socket)' failed > | ** (xfce4-panel:3603): CRITICAL **: Un élément a été inopinément supprimé: > "Contrôle d'espace disque". > `--- > > If you add it back, setting e.g. filemanager to thunar, everything goes > fine. It keeps on going fine even if you reset filemanager to an empty > string. Looks like a missing/buggy initialization. I couldn't reproduce because I'm not running any xfce panel atm. However I can tell that this problem isn't present in the 0.4.0 version (already in unstable and testing). I attach a quick patch that should just work. Btw, I don't see any 0.3.0-3 version in packages.d.o. > Miaou, > > -- > Cyril Brulebois mike
--- panel-plugin/fsguard.c.orig 2008-01-13 06:02:46.000000000 +0100
+++ panel-plugin/fsguard.c 2008-01-13 06:12:46.000000000 +0100
@@ -121,7 +121,7 @@
{
FsGuard *fsguard = user_data;
GString *cmd;
- if (strlen(fsguard->filemanager) == 0) {
+ if (fsguard->filemanager == NULL || strlen(fsguard->filemanager) == 0) {
return;
}
cmd = g_string_new (fsguard->filemanager);
signature.asc
Description: Digital signature
