Hi,

On Wed, Jan 16, 2008 at 08:51:48AM +0100, Giacomo Catenazzi wrote:
> I'm ready for a NMU, attached I put the diff.
> Now I'll upload the package in delayed.

Thanks, feel free to upload, but please see comments below.


>   Considering the package pourpose, maybe Architecture: "any"
>   is to wide.

Nope, don't think so. The package is supposed to work everywhere.


> diff -u awardeco-0.2/debian/changelog awardeco-0.2/debian/changelog
> --- awardeco-0.2/debian/changelog
> +++ awardeco-0.2/debian/changelog
> @@ -1,3 +1,11 @@
> +awardeco (0.2-2.1) unstable; urgency=low
> +
> +  * Non-Maintainer Upload at BSP in Zurich: fix rc bug
> +  * Use the C99 bit length integer, to be safe on various archs

Please add "(Closes: #438385)" here. Also, please end all changelog
lines with a full stop and start sentences with capital letters for
consistency.


> --- awardeco-0.2.orig/debian/patches/30_fixeduint.patch
> +++ awardeco-0.2/debian/patches/30_fixeduint.patch
> @@ -0,0 +1,17 @@
> +diff -Nur awardeco-0.2/src/awardeco.h awardeco-0.2.new/src/awardeco.h
> +--- awardeco-0.2/src/awardeco.h      2006-08-05 11:38:03.000000000 +0200
> ++++ awardeco-0.2.new/src/awardeco.h  2008-01-16 08:12:10.000000000 +0100
> +@@ -10,10 +10,11 @@
> + #define AWARDECO_H 1
> + 
> + #include    <stdio.h>
> ++#include    <stdint.h>
> + 
> + typedef unsigned char       byte;

Maybe make this uint8_t then, too, for consistency? Yes, it's more
cosmetical, but still.


Cheers, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to