Hi

Thanks for the patch. It will be applied.

Best regards,

// Ola

On Mon, Jan 21, 2008 at 11:31:31AM +0100, Bodo Meissner wrote:
> Package: giarpfanoa
> Version: 0.1.2
> Severity: minor
> Tags: patch
> 
> When I run giarpfanoa on my system, I get these two error messages:
> 
> /usr/share/giarpfanoa/hp-search-mac.mod: line 2: [: argument expected
> /usr/share/giarpfanoa/nbtscan.mod: line 3: [: argument expected
> 
> My system does not have the commands hp-search-mac or nbtscan. This leads
> to empty output of "which hp-search-mac" or "which nbtscan" and a missing
> argument to [ -x ].
> 
> The problem can be fixed by using quotes around the command output
> substitution as shown in the patch below.
> 
> 
> Bodo
> 
> 
> --- /usr/share/giarpfanoa/hp-search-mac.mod     2006-07-09 23:38:18.000000000 
> +0200
> +++ hp-search-mac.mod   2008-01-21 11:14:21.000000000 +0100
> @@ -1,5 +1,5 @@
>  # HP-search MAC
> -if [ ! -z "$MAC" -a -x $(which hp-search-mac) ] ; then
> +if [ ! -z "$MAC" -a -x "$(which hp-search-mac)" ] ; then
>      starttest HP-SEARCH-MAC $MAC
>      hp-search-mac $MAC
>      endtest
> --- /usr/share/giarpfanoa/nbtscan.mod   2006-07-09 23:38:18.000000000 +0200
> +++ nbtscan.mod 2008-01-21 11:14:31.000000000 +0100
> @@ -1,6 +1,6 @@
>  # NBTscan
>  
> -if [ ! -z "$IP" -a -x $(which nbtscan) ] ; then
> +if [ ! -z "$IP" -a -x "$(which nbtscan)" ] ; then
>      starttest "SMB/CIFS information $IP."
>      for I in $IP ; do
>         betweentest
> 
> 
> -- System Information:
> Debian Release: lenny/sid
>   APT prefers testing
>   APT policy: (900, 'testing'), (300, 'unstable'), (10, 'experimental')
> Architecture: i386 (i686)
> 
> Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core)
> Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
> 
> -- no debconf information
> 
> 
> 

-- 
 --------------------- Ola Lundqvist ---------------------------
/  [EMAIL PROTECTED]                     Annebergsslingan 37      \
|  [EMAIL PROTECTED]                     654 65 KARLSTAD          |
|  http://opalsys.net/                 +46 (0)70-332 1551       |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36  4FE4 18A1 B1CF 0FE5 3DD9 /
 ---------------------------------------------------------------



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to