On Tue, Feb 05, 2008 at 11:56:41AM +0000, Martin Guy wrote:
> Package: lua-gtk
> Version: 0.7-1
> Severity: wishlist
> 
> Please add "armel" and "armeb" to the Architectures: list for lua-gtk
> in debian/control since it builds fine there too. (See
> wiki.debian.org/ArmEabiPort)

Please compile&run the test file src/callback-test.c and give me
feedback.

lua-gtk defines a variadic function and casts it to a non variadic type.
On some architectures (the ones I listed in the architectures field)
there is no problem at all. On amd64 there is an ad-hoc fix since the
calling convention requires to put the number of float arguments on a
specific register. 

If the test fails It can be fixed studying the function calling
convention for variadic functions and properly fixing src/callback.c
as it was done for amd64.

> While you're at it, I think it would be better to put a single
> Architectures: clause in the Source: section instead of the same list
> in each Package: section.
> That means it is only built on architectures that want it, rather than
> being built on all and producing no packages on most.
> That would also mean that the Architectures: list appear in the main
> Sources file, which makes life easier for port maintainers because we
> can find Arch anomalies by grepping through the Sources file, rather
> than having to download every source package and grep debian/control,
> which is an unfeasibly immense task.

OK, I'll doo that

> ... or make Architecture: any and let buildd maintainers weed out the
> broken ports...

No. I won't put arch: any on a package I know will build everywhere but
not *run* properly.

To build and to run are *very* different tasks (that is also why I try
to attach to every package I upload a micro test that is run after the
compilation phase). I'll add such micro test to lua-gtk too ASAP, but
until then I'll not write arch: any.

Cheers
-- 
Enrico Tassi



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to