Package: twinkle
Severity: normal
Tags: patch
Hi,
Martin Michlmayr tried to build twinkle with GCC 4.3 and failed. The
first errors were caused by boost, so he filed the bug there (#454815).
While investigatng that bug, I have been using twinkle as a test case.
After fixing the bugs in boost itself, I found a number of things in
twinkle that need fixing to build with GCC 4.3. I'm attaching a patch
for them.
Cheers,
-Steve
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash
Versions of packages twinkle depends on:
ii kdelibs4c2a 4:3.5.8.dfsg.1-7 core libraries and binaries for al
ii libasound2 1.0.15-3 ALSA library
ii libc6 2.7-6 GNU C Library: Shared libraries
pn libccrtp1-1.3-0 <none> (no description available)
pn libcommoncpp2-1.3c2a <none> (no description available)
ii libgcc1 1:4.3-20080202-1 GCC support library
ii libgsm1 1.0.12-1 Shared libraries for GSM speech co
ii libqt3-mt 3:3.3.8b-1 Qt GUI Library (Threaded runtime v
ii libsndfile1 1.0.17-4 Library for reading/writing audio
ii libstdc++6 4.3-20080202-1 The GNU Standard C++ Library v3
ii libx11-6 2:1.0.3-7 X11 client-side library
ii libxext6 1:1.0.3-2 X11 miscellaneous extension librar
ii libxml2 2.6.31.dfsg-1 GNOME XML library
ii zlib1g 1:1.2.3.3.dfsg-11 compression library - runtime
twinkle recommends no packages.
diff -u -r twinkle-1.1/src/parser/hdr_allow.cpp fixed/src/parser/hdr_allow.cpp
--- twinkle-1.1/src/parser/hdr_allow.cpp 2007-01-07 07:47:34.000000000 +0000
+++ fixed/src/parser/hdr_allow.cpp 2008-02-11 05:25:03.000000000 +0000
@@ -18,6 +18,7 @@
#include "definitions.h"
#include "hdr_allow.h"
+#include <algorithm>
t_hdr_allow::t_hdr_allow() : t_header("Allow") {}
diff -u -r twinkle-1.1/src/parser/hdr_privacy.cpp fixed/src/parser/hdr_privacy.cpp
--- twinkle-1.1/src/parser/hdr_privacy.cpp 2007-01-07 07:47:34.000000000 +0000
+++ fixed/src/parser/hdr_privacy.cpp 2008-02-11 05:26:17.000000000 +0000
@@ -18,6 +18,7 @@
#include "definitions.h"
#include "hdr_privacy.h"
+#include <algorithm>
t_hdr_privacy::t_hdr_privacy() : t_header("Privacy") {};
diff -u -r twinkle-1.1/src/parser/media_type.cpp fixed/src/parser/media_type.cpp
--- twinkle-1.1/src/parser/media_type.cpp 2007-05-24 20:44:00.000000000 +0000
+++ fixed/src/parser/media_type.cpp 2008-02-11 05:27:46.000000000 +0000
@@ -18,6 +18,7 @@
#include "media_type.h"
#include "util.h"
+#include <cstdlib>
t_media::t_media() {
q = 1.0;
diff -u -r twinkle-1.1/src/sdp/sdp.cpp fixed/src/sdp/sdp.cpp
--- twinkle-1.1/src/sdp/sdp.cpp 2007-07-02 19:39:35.000000000 +0000
+++ fixed/src/sdp/sdp.cpp 2008-02-11 05:30:07.000000000 +0000
@@ -26,6 +26,7 @@
#include "parser/hdr_warning.h"
#include "parser/parameter.h"
#include "audits/memman.h"
+#include <algorithm>
string sdp_ntwk_type2str(t_sdp_ntwk_type n) {
switch(n) {
diff -u -r twinkle-1.1/src/sdp/sdp_parser.yxx fixed/src/sdp/sdp_parser.yxx
--- twinkle-1.1/src/sdp/sdp_parser.yxx 2007-01-07 07:47:34.000000000 +0000
+++ fixed/src/sdp/sdp_parser.yxx 2008-02-11 05:31:02.000000000 +0000
@@ -19,6 +19,7 @@
%{
#include <cstdio>
#include <string>
+#include <cstdlib>
#include "sdp_parse_ctrl.h"
#include "sdp.h"
#include "util.h"
diff -u -r twinkle-1.1/src/sockets/interfaces.cpp fixed/src/sockets/interfaces.cpp
--- twinkle-1.1/src/sockets/interfaces.cpp 2007-01-07 07:47:34.000000000 +0000
+++ fixed/src/sockets/interfaces.cpp 2008-02-11 05:32:36.000000000 +0000
@@ -18,6 +18,7 @@
#include "interfaces.h"
#include "url.h"
+#include <cstring>
t_interface::t_interface(string _name) : name(_name) {}
