Here's a forward of the discussion taken upstream.

-Pascal

---------- Forwarded message ----------
From: Pascal Giard <[EMAIL PROTECTED]>
Date: Feb 12, 2008 1:16 PM
Subject: Re: [SoX-devel] [patch] key, tempo broken on 64-bit architectures
To: [EMAIL PROTECTED], Sami Liedes <[EMAIL PROTECTED]>


On Feb 12, 2008 12:45 PM, Chris Bagwell <[EMAIL PROTECTED]> wrote:
> robs wrote:
> > --- Sami Liedes <[EMAIL PROTECTED]> wrote:
> >
> >> --- sox-14.0.0/src/tempo.c   2007-07-22 21:03:23.000000000 +0300
> >> +++ sox-debug/src/tempo.c    2008-01-17 17:17:28.000000000 +0200
> >> @@ -338,7 +338,8 @@
> >>                  sox_ssample_t * obuf, sox_size_t * isamp, sox_size_t *
> >> osamp)
> >>  {
> >>    priv_t * p = (priv_t *) effp->priv;
> >> -  sox_size_t i, odone = *osamp /= effp->ininfo.channels;
> >> +  sox_size_t i;
> >> +  size_t odone = *osamp /= effp->ininfo.channels;
> >>
> >
> > According to Sami, this fixes a seg-fault; does anyone here understand why 
> > that
> > should be?  And, if so, what are the rules regarding when one should use 
> > size_t
> > vs. sox_size_t?
> >
> >
> I don't understand why it would.  Any chance its on a 64-bit processor?
>
> Chris

Hello Sami,
 i haven't applied your patch in my latest Debian release as applying
your patch AS-IS breaks the build on my amd64. Therefore it requires
more investigation which i haven't had the time to do yet.

Also, could you please give an example of sox invocation which cause a
segfault on a 64bit cpu?

Cheers,

-Pascal
--
Homepage (http://organact.mine.nu)
Debian GNU/Linux (http://www.debian.org)
LACIME: École de technologie supérieure (http://lacime.etsmtl.ca)



-- 
Homepage (http://organact.mine.nu)
Debian GNU/Linux (http://www.debian.org)
LACIME: École de technologie supérieure (http://lacime.etsmtl.ca)


Reply via email to