On Tue, 12 Feb 2008 17:40:18 +0000, Dominic Hargreaves wrote:
> > Index: lib/MIME/Lite.pm
> > ===================================================================
> > --- lib/MIME/Lite.pm (revision 14794)
> > +++ lib/MIME/Lite.pm (working copy)
> > @@ -401,7 +401,7 @@
> > }
> > }
> > unless (-x $SENDMAIL) {
> > - Carp::croak "can't find an executable sendmail"
> > + Carp::carp "can't find an executable sendmail, you won't be able
> > to use send_by_sendmail()"
> > }
> > }
>
> I don't really think that's appropriate either. I haven't checked the
> behaviour of MIME::Lite with this conditional section removed (ie as per
> the patch on rt.cpan.org) but really it should behave gracefully itself.Agreed. > carp()ing isn't really appropriate here either. The error only needs to > appear if send_by_sendmail is used, and send should select sendmail if > available, and not otherwise. Right, that would involve moving the test into to send_by_sendmail() method. > BTW, I'm happy in principle to help out with team-maintained perl > packages, if that'd be useful - my alioth username is 'dom'. Thanks, that would by really appreciated! @dam, gwolf: Could you add dom please? @dom: If you haven't done so yet please take a look at http://pkg-perl.alioth.debian.org/ and the policy and subversion docs to get a feeling about our workflow. And http://pkg-perl.alioth.debian.org/cgi-bin/qareport.cgi shows the status and TODO for our packages. > Let me know if you will carry this forward or you would like me to > propose a patch for the behaviour described above. I'd be thankful if you found the time to prepare such a patch! Cheers, gregor -- .''`. http://info.comodo.priv.at/ | gpg key ID: 0x00F3CFE4 : :' : debian: the universal operating system - http://www.debian.org/ `. `' member of https://www.vibe.at/ | how to reply: http://got.to/quote/ `- NP: The Beatles: Golden Slumbers
signature.asc
Description: Digital signature
