Hi!
I would like to propose the patch which addresses this bug and makes sure
that the proper PID file is created, and the patch for the new package's
dependencies, since the init script has been modified to use the
/lib/lsb/init-functions.

Patch file attached.

Thanks!
--- irqbalance-0.55/debian/control	2008-02-18 20:25:17.000000000 +0100
+++ irqbalance-0.55/debian/control	2008-02-18 20:25:45.000000000 +0100
@@ -7,7 +7,7 @@ Standards-Version: 3.6.2.1
 
 Package: irqbalance
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}, lsb-base (>= 3.0-6)
 Description: Daemon to balance interrupts for SMP systems
  Daemon to balance interrupts across multiple CPUs, which can lead to
  better performance and IO balance on SMP systems. This package is
--- irqbalance-0.55/debian/irqbalance.init	2008-02-18 20:25:17.000000000 +0100
+++ irqbalance-0.55/debian/irqbalance.init	2008-02-18 20:25:45.000000000 +0100
@@ -37,31 +37,33 @@ if test "$ONESHOT" != "0"; then
     DOPTIONS="--oneshot"
 fi
 
+. /lib/lsb/init-functions
+
 case "$1" in
   start)
-        echo -n "Starting $DESC: "
+        log_begin_msg "Starting $DESC: $NAME"
         start-stop-daemon --start --pidfile $PIDFILE \
         	--name $PNAME --oknodo --startas $DAEMON \
             -- $OPTIONS $DOPTIONS
-        
-        echo "$NAME."
+        pidof $PNAME > $PIDFILE
+        log_end_msg $?
         ;;
   stop)
-        echo -n "Stopping $DESC: "
-        
+        log_begin_msg "Stopping $DESC: $NAME"
         start-stop-daemon --stop --pidfile $PIDFILE --name $PNAME --oknodo
-        
-        echo "$NAME."
+        rm -f $PIDFILE
+        log_end_msg $?
         ;;
   restart|force-reload)
-        echo -n "Restarting $DESC: "
+        log_begin_msg "Restarting $DESC: $NAME"
         start-stop-daemon --stop --pidfile $PIDFILE --name $PNAME \
             --retry 5 --oknodo
+        rm -f $PIDFILE
         start-stop-daemon --start --pidfile $PIDFILE \
             --name $PNAME --oknodo --startas $DAEMON \
             -- $OPTIONS $DOPTIONS
-        
-        echo "$NAME."
+        pidof $PNAME > $PIDFILE
+        log_end_msg $?
         ;;
   *)
         N=/etc/init.d/$SNAME

Reply via email to