Hi Tore, On Mon, May 09, 2005 at 02:04:25PM +0200, Tore Anderson wrote: > * Marc Haber > > The attached patch does this. I am not sure about whether the > > munin-contrib package needs a postinst as well, and the "hack" that > > munin-node's postinst uses to only initialize the plugins which have > > been installed new might not work any more. It is beyond my knowledge > > of the package to judge about that. > > Thanks! I skimmed it very quickly and it looks good to me.
Fine! > I'll > probably include it on the next upload. Only thing I wonder, wouldn't > it be better to use DEB_BUILD_OPTIONS to indicate that the contrib > package should be built? Probably. I mercilessly ripped the code from the exim4 package which does it like my patch does. Feel free to do it your way in your package ;) > Policy 10.1 doesn't say anything about it > being reserved for "noopt" and "nostrip" only, at least, and by using > an environment variable I can tell the user in README.Debian (or > wherever) to just run "DEB_BUILD_OPTIONS=munin-buildcontribpackage > apt-get --compile source munin" instead of doing it in several steps. apt-get --compile only works on unstable, and I expect a good fraction of munin installation to be backports on stable. > I don't think there should be a postinst with the plugins > automatically enabling themself. It's unsupported stuff, I'd like > people to know fully what they're doing if they're using them. So there also won't be any docs advising how to initialize? Will it, for example, matter whether munin-node or munin-contrib gets installed and configured first? The fact that the plugins need to be manually enabled should also be in the package description. > When > 1.2.0 was released I just grepped for half a minute and found around 10 > insecure tempfile uses in the contrib plugins - yuck. That should probably be in the package description. > I fixed those, but now the Solaris/BSD people are > complaining because they have no mktemp(1).. sigh, it's impossible to > please everyone. That's why autoconf/automake is in wide use ;) > > Please Cc: me on replies since I am not the original bug submitter. > > Sure, but there's no need to Cc: me as I get what's sent to the > [EMAIL PROTECTED] address anyway. PEBCAK on my part, sorry. Greetings Marc -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things." Winona Ryder | Fon: *49 621 72739834 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 72739835 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
