Package: ddclient Version: 3.7.3-4 Severity: normal Tags: patch-available I think there is a logic bug in ddclient's sanity checking of max-interval and min-interval. At the moment both checks use the max of the default value and the configured value, which doesn't limit the possible range. My assumption is that what the author intended was to use the max of the configured and default values for min-interval, and the min of the configured and default values for max-interval, thereby limiting the range effectively. A patch to this effect is attached.
Whatever the desired intention, this limiting needs to be mentioned in the help somewhere. At the moment most of the help is via the -help switch of ddclient, rather than the man page. This bug was discovered because DynDNS is writing to tell me that my account is due to expire after 30 days of inactivity, yet my /etc/ddclient.conf has max-interval=15d, which should force an update of my IP every 15 days. CC > -----Original Message----- > From: Chris Carr [mailto:[EMAIL PROTECTED] > Sent: 28 February 2008 07:55 > To: Peter Denison; Carr, Chris > Subject: ddclient > > Noz says: > Think I may have found the problem - it's a logic problem. > Noz says: > $opt{'max-interval'} = max(interval(opt('max-interval')), > interval(default('max-interval'))); > $opt{'min-interval'} = max(interval(opt('min-interval')), > interval(default('min-interval'))); > $opt{'min-error-interval'} = > max(interval(opt('min-error-interval')), > interval(default('min-error-interval'))); > > Noz says: > Surely you want to take the *minimum* of any maxima > specified, and the maximum of any minima specified ?? Don't you? > Noz says: > Line 1003 in /usr/sbin/ddclient on baba > -------- > Well, what this logic says is that you can set the > max-interval higher than the default but not lower, and you > can similarly set the min-interval higher than the default > but not lower. That could be what they want - but they need > to explain it somewhere. It's not mentioned on the ddclient > man page or in the copious output of ddclient -help. > > Will submit a bug report when I get to work. > > CC
ddclient.patch
Description: ddclient.patch
