Package: xosview
Version: 1.8.2-10
Severity: wishlist
Tags: patch, upstream

xosview currently only supports the xosview.cpuFormat resource only when
running on IRIX systems. Linux support seemed unnecessary for a long time
since 1-2 CPU systems were the norm, but this now becomes an issue now
that 8 core systems are not uncommon anymore.

The attached change adds support for xosview.cpuFormat in Linux:

diff -ru xosview-1.8.2/linux/MeterMaker.cc 
xosview-1.8.2.patched/linux/MeterMaker.cc
--- xosview-1.8.2.orig/linux/MeterMaker.cc      2004-05-21 22:10:35.000000000 
-0700
+++ xosview-1.8.2.patched/linux/MeterMaker.cc   2008-03-05 00:29:23.000000000 
-0800
@@ -37,9 +37,15 @@
 
   // Standard meters (usually added, but users could turn them off)
   if (_xos->isResourceTrue("cpu")){
-    int cpuCount = CPUMeter::countCPUs();
-    int start = (cpuCount == 0) ? 0 : 1;
-    for (int i = start ; i <= cpuCount ; i++)
+    int start, end;
+    if (strncmp (_xos->getResource("cpuFormat"),"single",2) == 0)
+      start = end = 0;
+    else {
+      end = CPUMeter::countCPUs();
+      start = (end == 0 ||
+               strncmp (_xos->getResource("cpuFormat"),"both",2) == 0) ? 0 : 1;
+    }
+    for (int i = start ; i <= end ; i++)
       push(new CPUMeter(_xos, CPUMeter::cpuStr(i)));
   }
   if (_xos->isResourceTrue("mem"))
diff -ru xosview-1.8.2/xosview.1 xosview-1.8.2.patched/xosview.1
--- xosview-1.8.2.orig/xosview.1        2008-03-05 00:33:08.000000000 -0800
+++ xosview-1.8.2.patched/xosview.1     2008-03-04 04:51:17.000000000 -0800
@@ -514,9 +514,6 @@
 
 xosview*cpuFormat: (single, all, both or auto)
 .RS
-IRIX only.
-.RE
-.RS
 If single, only a cumulative meter for all CPU is created. All creates a
 meter for each CPU, but no cumulative meter. Both creates one cumulative
 meter and one per cpu. auto behaves like single on uniprocessor system,

Hope this helps,

-- 
Michel Lespinasse



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to