On Mon, Mar 17, 2008 at 01:58:09PM +1100, Vincent McIntyre wrote:
> Package: dh-make-php
> Version: 0.2.0
> Severity: normal
> Tags: patch
> thanks
>
> *** Please type your report below this line ***
>
> Hi,
>
> I am trying to use this package to build oci-8.2.4, viz:
> # dh-make-pecl --only 5 oci8
>
> This appears to download the tar file ok, but then it doesn't
> extract any information in the eval_package() function.
> For example the call to set the VERSION variable (set -x; set-v output):
>
> xsltproc --nonet --novalid --param Element "/package/release/version"
> ${PREFIX}/share/dh-make-php/xslt/common.xsl package.xml
> ++ xsltproc --nonet --novalid --param Element /package/release/version
> /usr/share/dh-make-php/xslt/common.xsl package.xml
> + VERSION=
>
> Could this be because the package.xml layout has changed?
> I'm no expert with xml parsing.
That could be and newer versions of dh-make-pecl are much more
robust when reading the package.xml file. Actually, they don't
use xsltproc anymore but a php script which used the pear class
for reading package.xml files. That class should handle all
possible flavours.> I have a suggestion for the dh-make-pecl script; could it not check for > unset or blank variables before charging on and making a mess in the > working directory, with directories named 'php--' and so on? > I've attached a patch that does what I would like to see, perhaps it > needs expanding and/or applying to dh-make-pear. > Perhaps it would be better to do the test in eval_package and return > a failure if variables that should always have a value are blank? Though I suspect that your problem is fixed with a newer version of dh-make-pecl, it sounds like a good idea to do some more error handling. I'll see if your patch still make sense for newer verions. Uwe -- MMK GmbH, Fleyer Str. 196, 58097 Hagen [EMAIL PROTECTED] Tel: 02331 840446 Fax: 02331 843920
signature.asc
Description: Digital signature
