Hi Alasdair,

On Mon, May 16, 2005 at 04:21:15PM +0200, Florian Weimer wrote:
> * Alasdair McWilliam:
> > Change to:
> >
> > AC_CHECK_FUNCS([times index rindex setlinebuf va_copy __va_copy])
> 
> va_copy is a macro, so this check won't work reliably.

Florian usually knows what he is talking about, so I'd rather refrain
from applying your patch.

> On Debian, it's safe to use va_copy unconditionally because it's part
> of GCC's <stdarg.h> header.

Knowing that rageircd is not only meant for Debian, I'd suggest using
the code from Thiemo, patch repeated:

--- ./include/common.h  2004-12-07 03:04:34.000000000 +0000
+++ /tmp/dpep-work.aVeWMw/rageircd-2.0.0/include/common.h
2005-05-15 14:07:40.192791162 +0000
@@ -48,17 +48,10 @@
 #define ASSERT(xx)
 #endif

-/* VA_COPY - namely for x86_64 and PowerPC architectures.
- * Copyright Rossi 'vejeta' Marcello ([EMAIL PROTECTED])
- */
-#ifdef __powerpc__
-#ifdef __NetBSD__
-#define VA_COPY va_copy
-#elif defined(__FreeBSD__) || defined(__linux__)
-#define VA_COPY __va_copy
-#endif
-#elif defined(__x86_64)
+#if defined(__GNUC__) || (defined(__powerpc__) && defined(__FreeBSD__))
 #define VA_COPY __va_copy
+#elif defined(__powerpc__) && defined(__NetBSD__)
+#define VA_COPY va_copy
 #else
 #define VA_COPY(x, y) x = y
 #endif

Would that be ok with both of you?

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to