Bug#473805: acerhk: remove world write permissions

[Javier Serrano Polo]

Package: acerhk
Version: 0.5.35-2
Severity: normal
Tags: patch security

Please remove the initial world write permissions (see attachment). You
may enable group access adding this in /etc/modprobe.d/:
install acerhk modprobe --ignore-install acerhk $CMDLINE_OPTS && chgrp cdrom 
/proc/driver/acerhk/*

Consider adding an acerhk group.

--- acerhk.c.orig	2008-03-31 22:53:50.000000000 +0200
+++ acerhk.c	2008-04-01 19:46:57.000000000 +0200
@@ -2700,7 +2700,7 @@
       } else {
         entry->owner = THIS_MODULE;
         /* ... and led control file */
-        entry = create_proc_entry("led", 0222, proc_acer_dir);
+        entry = create_proc_entry("led", 0220, proc_acer_dir);
         if (entry == NULL) {
           printk(KERN_INFO"acerhk: cannot create LED file\n");
           remove_proc_entry("info", proc_acer_dir);
@@ -2712,7 +2712,7 @@
           entry->write_proc = acerhk_proc_led;
           entry->owner = THIS_MODULE;
           /* ... and wireless led controll file */
-          entry = create_proc_entry("wirelessled", 0222, proc_acer_dir);
+          entry = create_proc_entry("wirelessled", 0220, proc_acer_dir);
           if (entry == NULL) {
             printk(KERN_INFO"acerhk: cannot create wirelessled file\n");
             remove_proc_entry("info", proc_acer_dir);
@@ -2725,7 +2725,7 @@
             entry->write_proc = acerhk_proc_wirelessled;
             entry->owner = THIS_MODULE;
             /* ... and bluetooth led controll file */
-            entry = create_proc_entry("blueled", 0222, proc_acer_dir);
+            entry = create_proc_entry("blueled", 0220, proc_acer_dir);
             if (entry == NULL) {
               printk(KERN_INFO"acerhk: cannot create blueled file\n");
               remove_proc_entry("info", proc_acer_dir);
@@ -2740,7 +2740,7 @@
               retval = 1;
 #ifdef ACERDEBUG
               /* add extra file for debugging purposes */
-              entry = create_proc_entry("debug", 0222, proc_acer_dir);
+              entry = create_proc_entry("debug", 0220, proc_acer_dir);
               if (entry == NULL) {
                 printk(KERN_INFO"acerhk: cannot create debug file\n");
                 remove_proc_entry("info", proc_acer_dir);