tag 474097 - patch
thanks

On Thu, Apr 03, 2008 at 12:32:11PM +0200, Arthur Loiret wrote:

> Tags: patch

Removing this since I'm asking for changes.

> +N32-ARCHS=mips mipsel
> +ifneq (,$(findstring $(DEB_HOST_ARCH), $(N32-ARCHS)))
> +EXTRA_INSTALL+=installn32
> +EXTRA_BUILD+=buildn32-stamp
> +m64=-mabi=64
> +mn32=-mabi=n32
>  endif

The patch looks good but could you please rearrange it so that the
overriding of -m64 for MIPS is done in the 64-ARCHS test block rather
than here?  Something along the lines of:

  # MIPS doesn't use -m64
  ifneq (,$(findstring $(DEB_HOST_ARCH), mips mipsel))
  m64=-mabi=64
  else
  m64=-m64
  endif

ought to do the trick.  I'd rather take a known-tested patch than modify
it myself without testing.

Thanks for the patch!

-- 
"You grabbed my hand and we fell into it, like a daydream - or a fever."



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to