Hi Alan,

Posting to the news.supernews.com nntp server, as configured since
31 March 2008, using inews -h, fails with "you do not have
permission to post", because the nntp server responds to the
initial post command with a "480 authentication required" response.
inews.c, receiving what is not an "ok" response, terminates the
connection rather than attempting to offer the article
(at which point authentication, if required, is offered by inews).

As you mention in your second mail in this thread, Supernews is not
RFC compliant with that return code.  It should not send a 480 answer
but 200/201 for instance.


+++ inn-2.4.3/frontends/inews.c 2008-04-08 13:10:39.000000000 -0500
- if (i != NNTP_POSTOK_VAL)
+ if ((i != NNTP_POSTOK_VAL) && (i != NNTP_AUTH_NEEDED_VAL))
            die("you do not have permission to post");

In order to be more general (that is to say not specific to Supernews
and its return value), I would suggest:


===================================================================
--- frontends/inews.c   (révision 7765)
+++ frontends/inews.c   (copie de travail)
@@ -989,8 +989,12 @@
       if ((j = atoi(buff)) != NNTP_BAD_COMMAND_VAL)
           i = j;

-       if (i != NNTP_POSTOK_VAL)
-            die("you do not have permission to post");
+        if (i != NNTP_POSTOK_VAL) {
+            /* We try to authenticate in case it is all the same possible
+             * to post. */
+            if (NNTPsendpassword((char *)NULL, FromServer, ToServer) < 0)
+                die("you do not have permission to post");
+        }
       deadfile = NULL;
    }



Indeed, this code has also the advantage to work with that:

9:59 [EMAIL PROTECTED] ~% telnet localhost 1190
Trying 127.0.0.1...
Connected to localhost.localdomain.
Escape character is '^]'.
200 test-INN-2.4.4 InterNetNews server INN 2.4.4 (20080411 prerelease) ready
mode reader
201 test-INN-2.4.4 InterNetNews NNRP server INN 2.4.4 (20080411 prerelease) 
ready (no posting).
post
440 Posting not allowed
authinfo user xxx
381 PASS required
authinfo pass xxx
281 Ok
post
340 Ok, recommended ID <[EMAIL PROTECTED]>
.
441 Article has no body -- just headers
quit
205 .


Without the patch, no article can be sent (because of the *201* return answer).
By the way, as we have afterwards *440* (and not 480), inews would also not
have tried to authenticate by itself!

Regards,

--
Julien ÉLIE

« En fait, je n'ai qu'une prétention, c'est de ne pas
 plaire à tout le monde. Plaire à tout le monde, c'est plaire
 à n'importe qui. » (Sacha Guitry)



Reply via email to