Package: elscreen
Version: 1.4.3-1
Severity: normal
Tags: patch

Hi,

When byte-compiling elscreen for emacs22, I got following warnings:

In toplevel form:
elscreen-dnd.el:36:1:Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon.  See (elisp)Backquote in the manual.
elscreen-dnd.el:54:1:Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon.  See (elisp)Backquote in the manual.

So, could you please switch to the newer Emacs Lisp backquote syntax? It
does not harm because the older syntax has been obsolete so long and I
find the newer one has already been used in other files of elscreen.

I attach a patch to (maybe) fix this issue.

Thanks,

-nori


-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-686
Locale: LANG=ja_JP.eucJP, LC_CTYPE=ja_JP.eucJP (charmap=EUC-JP)

Versions of packages elscreen depends on:
ii  apel                   10.6+0.20060424-1 portable library for emacsen

elscreen recommends no packages.

-- no debconf information
--- elscreen-dnd.el.orig        2008-05-16 13:39:18.000000000 +0900
+++ elscreen-dnd.el     2008-05-16 13:42:03.000000000 +0900
@@ -34,10 +34,10 @@
 ;; Code:
 
 (defmacro elscreen-dnd-drag-n-drop (ad-do-it)
-  (` (progn
+  `(progn
        (elscreen-notify-screen-modification-suppress
-       (, ad-do-it))
-       (elscreen-notify-screen-modification 'force))))
+       ,ad-do-it)
+       (elscreen-notify-screen-modification 'force)))
 
 (defadvice dnd-handle-one-url (around elscreen-dnd-handle-open-url activate)
   (if (not elscreen-dnd-open-file-new-screen)
@@ -53,6 +53,6 @@
 
 (mapc
  (lambda (drag-n-drop-function)
-   (eval (` (defadvice (, drag-n-drop-function) (around 
elscreen-dnd-drag-n-drop activate)
-             (elscreen-dnd-drag-n-drop ad-do-it)))))
+   (eval `(defadvice ,drag-n-drop-function (around elscreen-dnd-drag-n-drop 
activate)
+             (elscreen-dnd-drag-n-drop ad-do-it))))
  (list 'x-dnd-handle-drag-n-drop-event 'mac-drag-n-drop 'w32-drag-n-drop))

Reply via email to