[I removed [EMAIL PROTECTED] from CC to avoid bounces due to not being
subscribed]
On Sa Mai 3 2008, John Hasler wrote:
> Please test this patch to ntp_core.c on a pristine upstream 1.23:
>
>
> --- ../pristine/chrony-1.23/ntp_core.c 2008-05-02 22:14:21.000000000 -0500
It seems that these timevals do not always end up in offset_time. A
$ grep offset_time *.c
reveals that offset_time is set (all other occurences of offset_time are
either reads or modifications through UTI_* functions) in exactly one place:
line [EMAIL PROTECTED], within SST_DoNewRegression
Inspection of the surrounding code shows that the assignment depends on
condition 'regression_ok'.
There is no assignment in the else block at line 489. I confirmed with the
debugger that this spot is reached before any reads/modifications take place,
so this would be one place to put a fix. I have no idea what would be a good
replacement value.
Looking at the places calling SST_DoNewRegression and others it seems possible
that enough samples can be dropped that regression_ok becomes false after it
has been true before. In that case inst->sample_times[inst->n_samples - 1]
might be better than {0, 0} if n_samples > 0.
The canonical place to initialize offset_time = {0, 0} would be
SST_CreateInstance.
Best regards,
Peter Pöschl
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
