Bug#481482: When no proxy is specified mpdscribble segfaults in libsoup

[Jeroen Massar]

Package: mpdscribble
Version: 0.2.12-10
Severity: grave
Followup-For: Bug #481482

mpdscribble crashes because of this "fix" when no proxy is being used.



$ gdb mpdscribble
GNU gdb 6.8-debian
Copyright (C) 2008 Free Software Foundation, Inc.

I rebuild the package, but disabling dh_strip from the rules file so that I had symbols and then got: License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu"...
(gdb) r
Starting program: /usr/bin/mpdscribble
[Thread debugging using libthread_db enabled]
[New Thread 0x7f0aab968780 (LWP 11056)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f0aab968780 (LWP 11056)]
0x00007f0aaa836920 in strchr () from /lib/libc.so.6
(gdb) bt
#0  0x00007f0aaa836920 in strchr () from /lib/libc.so.6

#2  0x00007f0aaaf5e1fe in soup_uri_new () from /usr/lib/libsoup-2.2.so.8
#3  0x0000000000403597 in conn_setup () at conn.c:91

(gdb) quit


Simple fix for me, on line 91:

  /*g.proxy = soup_uri_new(file_config.proxy);*/

Most likely easier fix: check if file_config.proxy is set or not.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.25-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages mpdscribble depends on:
ii  adduser                       3.107      add and remove users and groups

ii  libc6                         2.7-11     GNU C Library: Shared libraries
ii  libglib2.0-0                  2.16.3-2   The GLib library of C routines

ii  logrotate                     3.7.1-3    Log rotation utility


mpdscribble recommends no packages.

-- debconf information excluded

#1 0x00007f0aaaf5db23 in soup_uri_new_with_base () from /usr/lib/libsoup-2.2.so.8 #4 0x0000000000401e5a in main (argc=1, argv=0x7fffb3a8b708) at mpdscribble.c:86 ii debconf [debconf-2.0] 1.5.22 Debian configuration management sy ii libmpd0 0.15.0-3 High-level client library for acce ii libsoup2.2-8 2.2.105-4 an HTTP library implementation in ii lsb-base 3.2-12 Linux Standard Base 3.2 init scrip

signature.asc
Description: OpenPGP digital signature