On Thu, May 29, 2008 at 12:39:28AM +1000, Tim Connors wrote: > Package: nvidia-kernel-source > Version: 169.12-4 > Severity: normal > > In the latest 2 versions, the xen and other patches seem to be applied > in the wrong direction. This is from a fresh rm -rf modules/ ; tar > xvf ... ; make-kpkg clean .... with both the clean and configure > steps wanting to apply the patch in the wrong direction. If I confirm > both the clean and configure patches to assume -R, then it builds > successfully (otherwise it bails because the patch step has failed). > Then because the patch has then been reversed by the time configure > finishes, the actual build of the binary modules will want to apply > the patch in the direction given, without assuming -R. Haven't > verified whether it runs yet.
I think the correct thing to do is to apply the patches in the package build step and not try to do it in the clean/configure steps at all. It's simply a mess to do it there. Clean should do it in reverse if at all. The rules already has a place to apply patches while building the module source package, which works well, why are we not using it? -- Len Sorensen -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

