tag 483651 upstream thanks On Fri, May 30, 2008 at 11:04:36AM +0200, Sebastian Harl wrote: > Package: libperl5.10 > Version: 5.10.0-10 > Severity: normal
> In Perl 5.8, Perl_av_clear(), Perl_av_undef() and possibly other API > functions simply returned without doing anything, if the AV * argument > was NULL: > > if (!av) > return; > > In Perl 5.10, this has been changed to an assertion: > > assert(av); > > Now, this imho is a regression for the following reasons: > > - Old code which relies on those functions handling NULL pointers > safely is now broken. That code will now either trigger the assertion > or simply segfault (if NDEBUG was defined when building Perl). > > - Imho, library functions should never cause a program to abort because > of invalid arguments (at least, in cases which are equally frequent > as this one). > > I would really like to see those changes reverted. I did not use > severity "wishlist" because this has a (minor) impact on the usability > of libperl. This was not accidental. Please see the upstream discussion starting at http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2006-01/msg00702.html I don't think it makes sense to diverge from upstream here, so please bring this up on the perl5-porters list if you think you can convince them otherwise. -- Niko Tyni [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
